-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add unit tests to RFP-related functions #1203
Conversation
} else { | ||
e.Listeners[eventType] = []chan interface{}{listenerToAdd} | ||
} | ||
e.Listeners[eventType] = append(e.Listeners[eventType], listenerToAdd) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gofmt linter was requesting this code change: https://staticcheck.io/docs/checks#S1036
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work. Just fix those the two nits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
This diff aims to increase test coverage to functions related to the RFP process recently merged in the repo. Besides adding proposal tests, this diff moves test helper functions (
new...
) totesting.go
for better modularity.Tests added:
Smaller tests added:
If any of the smaller tests added are deemed to make the code brittle and hard to change, let me know and I can remove or modify them.